Test: Support multiple threads writing to subprocess_results.log#1877
Open
heifner wants to merge 2 commits intoAntelopeIO:mainfrom
Open
Test: Support multiple threads writing to subprocess_results.log#1877heifner wants to merge 2 commits intoAntelopeIO:mainfrom
heifner wants to merge 2 commits intoAntelopeIO:mainfrom
Conversation
Contributor
|
Wouldn't the following work and avoid re-opening the file every time with Utils._check_output_lock:
if not hasattr(Utils, "checkOutputFile"):
Utils.checkOutputFilename=f"{Utils.DataPath}/subprocess_results.log"
if Utils.Debug: Utils.Print("opening %s in dir: %s" % (Utils.checkOutputFilename, os.getcwd()))
Utils.checkOutputFile=open(Utils.checkOutputFilename,"w")
with Utils._check_output_lock:
Utils.checkOutputFile.write(Utils.FileDivider + "\n")
Utils.checkOutputFile.write("start={%s}\n" % (time))
Utils.checkOutputFile.write("cmd={%s}\n" % (" ".join(cmd)))
Utils.checkOutputFile.write("cout={%s}\n" % (output))
Utils.checkOutputFile.write("cerr={%s}\n" % (error))
Utils.checkOutputFile.write("stop={%s}\n" % (stop)) |
Contributor
Author
I kind of like opening to append each time. The close makes sure it is flushed. Not like performance matters here. |
Contributor
|
Sound fine. Still I think we should take the lock for the open as well to avoid contention when writing into |
greg7mdp
approved these changes
Dec 4, 2025
cc32d9
added a commit
to eos-amsterdam-rnd/antelope_spring_ce
that referenced
this pull request
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The read only tests use multiple threads to push transactions. These end up trying to write to the
subprocess_results.logat the same time. Protect the write with a lock.